This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Fix breadcrumb component ellipsis #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
suggested changes
Feb 3, 2020
Added overflow: hidden on the main element of the oc-breadcrumb to make sure that it can ellipsize its content in responsive mode.
PVince81
force-pushed
the
breadcrumb-ellipsis
branch
from
56f8f38
to
4f524fc
Compare
|
@LukasHirt adjusted accordingly, thanks for pointing in the right direction :-) |
kulmann
approved these changes
Feb 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added overflow: hidden on the main element of the oc-breadcrumb to make
sure that it can ellipsize its content in responsive mode.
Before this fix it would just overflow.
You can also try this in Phoenix by having long folder names and adding "overflow:hidden" on that element and see the difference.