-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fonts / layout too big #1902
Comments
In my opinion the font-size of 15px is actually quite okay. It's only 1px difference compared to Github's 14px. What is different though is that GitHub's layout is more condensed, especially when it comes to row heights and general white space. Having said that (and not being a graphic designer) GitHub's condensed UI is not perfect and whitespace and clear structures are normally a good thing. Accessibility-wise, when it comes to overview, what is related to what and overall "UI calmness", the current phoenix UI does a good job. But I still get your point. The possibilities to resolve are:
If UX/design is aware of this possibility, it could take these potential solutions into consideration during UX refinements (@wuenschedesign) |
@marcus-herrmann is this still relevant after the re-design? |
@pascalwengerter No, I think not |
Closing this since it's not an accessibility issue and seems okay for now. @tbsbdr please shout if you receive user feedback regarding font sizes (will also be customizable via theming soon btw) |
On my laptop's screen 1920x1080 with HiDPI and zoom 100%:
![image](https://user-images.githubusercontent.com/277525/64349375-1fdd9d80-cff7-11e9-94eb-710bb95293a9.png)
Compare this to Github in the same browser and same zoom factor:
![image](https://user-images.githubusercontent.com/277525/64349400-2f5ce680-cff7-11e9-9d57-2e7f35afac43.png)
I think we should reduce the font size a bit to match what other websites are using.
Currently I need to reduce the zoom factor on my screen to be able to properly appreciate the public link panel or sharing panel. Should we aim to make those panels fit on the screen with such resolution ? (it won't fit on mobile and that's ok)
The text was updated successfully, but these errors were encountered: