Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumpy error message in folder creation dialog #1906

Closed
PVince81 opened this issue Sep 5, 2019 · 3 comments · Fixed by #3240
Closed

Jumpy error message in folder creation dialog #1906

PVince81 opened this issue Sep 5, 2019 · 3 comments · Fixed by #3240
Assignees
Labels
Type:Bug Something isn't working Type:Design

Comments

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2019

Steps to reproduce

  1. Create a folder "test" and validate.
  2. Create another folder and type "test" in the dialog

Expected behaviour

Smooth error message

Actual behaviour

Error message brutally appears as soon as I hit the last "t" and pushes the whole UI down.
It feels painful when my eyes focus on the field while I'm typing and suddenly it jumps down.

Not sure if adding a smooth animation here would help or whether we push the error message below the field ?

Version

Phoenix master 2f7b3d7

@LukasHirt
Copy link
Contributor

I think pushing it bellow would be a better solution. Also dropping the whole frame and using only a red text + change the border colour of the input to red maybe?

@PVince81 PVince81 added this to the backlog milestone Sep 24, 2019
@PVince81 PVince81 modified the milestones: backlog, Milestone 1: Phoenix for users Sep 30, 2019
@PVince81 PVince81 added the Type:Bug Something isn't working label Sep 30, 2019
@jnweiger
Copy link
Contributor

jnweiger commented Oct 1, 2019

Suggestion: Put the message next to the [OK] button. It belongs there, as it explains why the button is grayed out. That is also 'below', and nothing jumps up and down any more.

@LukasHirt
Copy link
Contributor

Put the message next to the [OK] button. It belongs there, as it explains why the button is grayed out.

This becomes a problem on smaller devices.

@kulmann kulmann self-assigned this Mar 22, 2020
@kulmann kulmann mentioned this issue Mar 22, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working Type:Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants