Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations broken on adding/deleting public links or collaborators #2937

Closed
kulmann opened this issue Jan 30, 2020 · 1 comment · Fixed by #2952
Closed

Animations broken on adding/deleting public links or collaborators #2937

kulmann opened this issue Jan 30, 2020 · 1 comment · Fixed by #2952
Assignees
Labels
Interaction:Discussion Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Jan 30, 2020

When a public link or collaborator is added or removed, the transition-group on the respective list can't do it's job (sliding in the new list item / out the removed one) because the links/shares receive a LINKS_LOADING / SHARES_LOADING state in the store. I think we're overusing the mutation - the animation would already do the job of showing a change in the respective list UI. Triggering the loading progress bar through the mutation is a) not necessary and b) (more important) disrupts the UI, as the whole panel is hidden while the loader is shown.

I would like to remove the mutation on adding and removing links/collaborators. Thoughts and concerns about this?

@kulmann kulmann added Type:Bug Something isn't working Interaction:Discussion labels Jan 30, 2020
@kulmann kulmann self-assigned this Jan 30, 2020
@PVince81
Copy link
Contributor

As discussed, we can remove the progress bar for "save" operations as we already have a spinner in the edit form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interaction:Discussion Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants