Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect url with query parameters #3285

Closed
C0rby opened this issue Apr 2, 2020 · 11 comments · Fixed by #3291
Closed

Redirect url with query parameters #3285

C0rby opened this issue Apr 2, 2020 · 11 comments · Fixed by #3291
Assignees
Labels
QA:p2 QA:team Type:Bug Something isn't working

Comments

@C0rby
Copy link
Contributor

C0rby commented Apr 2, 2020

This is important to get the logout finally working.
After a user logs out the oidc provider sends a redirect to https://localhost:9200?state=.
If the user tries to login again it won't work because the url is incorrect. The query parameter must be placed to another position.

Steps to reproduce

Logout of phoenix

Expected behaviour

The page gets redirected to login and the url looks like this
https://localhost:9200/#/login?state=

Actual behaviour

The page gets redirected to login and the url looks like this
https://localhost:9200/?state=#/login

Client configuration

Browser:
Any browser

@C0rby C0rby added the Type:Bug Something isn't working label Apr 2, 2020
@C0rby
Copy link
Contributor Author

C0rby commented Apr 3, 2020

Some things I found:
vuejs/vue-router#2125

@C0rby
Copy link
Contributor Author

C0rby commented Apr 3, 2020

I think the easiest way would be to set baseUrl + '#/login' as the redirect uri.

@C0rby C0rby mentioned this issue Apr 3, 2020
9 tasks
@individual-it
Copy link
Member

reopening and adding QA-team label to add tests

@Talank
Copy link
Contributor

Talank commented May 25, 2020

It looks like the pattern of redirect uri is not fixed. I tried to reproduce the issue using the current phoenix build with ocis backend. I am still being redirected to https://localhost:9200/?state=#/login

@C0rby
Copy link
Contributor Author

C0rby commented May 25, 2020

Can you provide more context? Are you doing the logout manually?
The fix was working fine with ocis so I'm a bit suprised.

@Talank
Copy link
Contributor

Talank commented Jun 1, 2020

When I do log out manually, then it takes me to https://localhost:9200/#/login?state= but when I try to go to https://localhost:9200?state= it takes me to https://localhost:9200/?state=#/login

@C0rby
Copy link
Contributor Author

C0rby commented Jun 2, 2020

Why would you like to go to https://localhost:9200?state=? I mean why do you need the state attribute? It's only needed for the openid flow.

@individual-it
Copy link
Member

Why would you like to go to https://localhost:9200?state=? I mean why do you need the state attribute? It's only needed for the openid flow.

because that is what the issue says :

Steps to reproduce
Try to open https://localhost:9200?state=

is there an misunderstanding?

@C0rby
Copy link
Contributor Author

C0rby commented Jun 3, 2020

Ah right, sorry....
I totally didn't get that.. Yeah the issue description is incorrect.
Let me change that

@individual-it
Copy link
Member

@C0rby 👍 THX for clarification
@Talank lets just add UI tests where the user logs out using the UI and then tries to login again, if that works in all the environments we test automatically we should be fine

@haribhandari07 haribhandari07 added this to Sprint Backlog in oCIS Sprint 20-11 via automation Jun 4, 2020
@haribhandari07 haribhandari07 moved this from Sprint Backlog to In progress in oCIS Sprint 20-11 Jun 4, 2020
@haribhandari07 haribhandari07 added this to Sprint Backlog in oCIS Sprint 20-12 via automation Jun 8, 2020
@PVince81 PVince81 moved this from Sprint Backlog to Todo in oCIS Sprint 20-12 Jun 8, 2020
@PVince81 PVince81 moved this from Todo to In progress in oCIS Sprint 20-12 Jun 8, 2020
@dpakach
Copy link
Contributor

dpakach commented Jun 19, 2020

tests done in #3572

@dpakach dpakach closed this as completed Jun 19, 2020
oCIS Sprint 20-12 automation moved this from In progress to Done Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:p2 QA:team Type:Bug Something isn't working
Projects
No open projects
oCIS Sprint 20-11
  
In progress
Development

Successfully merging a pull request may close this issue.

4 participants