Transform route titles into real h1's, for #1651 #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
💥 Acceptance tests Account failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7145/
|
💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7145/
|
💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7145/
|
💥 Acceptance tests iPhone failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7145/
|
💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7145/
|
💥 Acceptance tests Resharing failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7145/
|
PVince81
force-pushed
the
feature/h1-for-every-route
branch
from
674c8a0
to
c2087c7
Compare
|
Rebased. @LukasHirt please review |
LukasHirt
reviewed
Dec 17, 2019
LukasHirt
reviewed
Dec 17, 2019
Use generic visually hidden, page title helper class, established in DS for #1651 Added v-text and changed selector for account page title
LukasHirt
force-pushed
the
feature/h1-for-every-route
branch
from
c2087c7
to
50b9b16
Compare
|
@PVince81 I adjusted the PR to use |
micbar
added a commit
that referenced
this pull request
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transformed spans the held the page title to actual h1 elements. In the case of the file list a h1 is existing for accessibility reasons, but can only be perceived via a screen reader (is "visually-hidden").
Related Issue
Motivation and Context
Screen reader users navigate by large extent by a documents or web apps headline structure. At least one level 1 headline should exist to make the pages (routes) purpose, content or function clear.
How Has This Been Tested?
work in progress
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: