Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved collaborators additional info into own row #3130

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Moved collaborators additional info into own row #3130

merged 1 commit into from
Mar 5, 2020

Conversation

LukasHirt
Copy link
Contributor

@LukasHirt LukasHirt commented Mar 3, 2020 •
edited

Description

Moved additional info of collaborator to own row, removed row with the type of collaborator, included type as an aria-label and refactored related tests.

How Has This Been Tested?

  • test environment: Acceptance tests

Screenshots (if appropriate):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt self-assigned this Mar 3, 2020
@update-docs
Copy link

update-docs bot commented Mar 3, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt LukasHirt force-pushed the feature/additional-info-on-new-row branch 2 times, most recently from b8d90bf to d8c5cfd Compare March 4, 2020 15:19
@LukasHirt LukasHirt marked this pull request as ready for review March 4, 2020 15:19
@LukasHirt LukasHirt requested a review from PVince81 March 4, 2020 15:20
@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer and removed Status:In-Progress labels Mar 4, 2020
@LukasHirt LukasHirt force-pushed the feature/additional-info-on-new-row branch 5 times, most recently from d0d2286 to 64f7712 Compare March 4, 2020 20:25
@LukasHirt
Removed share type and moved additional info on its own row
51b6cc2 
Refactor autocomplete select test

Use indicator to retrieve collaborator type

Refactor assert in autocomplete list

Bring back remote collaborator type
@LukasHirt LukasHirt force-pushed the feature/additional-info-on-new-row branch from 64f7712 to 51b6cc2 Compare March 4, 2020 20:27
PVince81
PVince81 approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js Show resolved Hide resolved
@PVince81 PVince81 merged commit 203f09a into master Mar 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/additional-info-on-new-row branch March 5, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasHirt @PVince81