-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move indicators under resource name #3617
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
fde5ff0
to
1313a65
Compare
0731e86
to
0fc3fb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments + this UX concerns:
- When hovering a files list row, the resource name gets highlighted (underlined). This also happens when you hover over the indicators. Which is a bit confusing, because you would expect a) the indicator to be highlighted, or b) nothing to be highlighted.
- The sharing status row is now part of the file item. The
Shared with me
,Shared with others
andTrash bin
file views don't support this. TheShared with others
file view even has aCollaborators
column, which would then replace overrule the sharing state under the resource name. We have to think this through and it widens the scope of this PR a lot.
0fc3fb6
to
b692745
Compare
@kulmann I've removed the underline effect when hovering over the indicators and display it only when hovering the name directly. It's done directly via styles in the component same as the sizes of the preview. I'd like to adjust the ODS component to handle two rows and then move the styles in there as well. I've also hidden the second row in all the lists but all files and favourites as you correctly mentioned that it doesn't make much sense in there with the current implementation. The changelog is also adjusted with your proposal 😉 I haven't unfortunately figured out what to do with the tests. I cannot reproduce the error locally either when running the tests or manually. I guess it cannot find some resources, but that doesn't really make sense to me, that it doesn't do in more scenarios and why does it pass locally. |
b692745
to
a10db53
Compare
6156f09
to
a10db53
Compare
There was a bug in the test code that was scrolling through the file list and checking if the file was visible. Because of that, some elements would not be seen as visible no matter how much it scrolled. |
Opened an issue for labels - #3673 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adjust row selectors Use correct row size Use two rows only in all files list and favorites list Truncate the resource name
d106fb1
to
a075971
Compare
Motivation and Context
Better separation from quick actions -> probably only temporarily solution (will be tested with real users).
Screenshots (if appropriate):
Types of changes