Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to accordions in the sidebar #4249

Merged
merged 25 commits into from
Oct 29, 2020
Merged

Switch to accordions in the sidebar #4249

merged 25 commits into from
Oct 29, 2020

Conversation

LukasHirt
Copy link
Contributor

No description provided.

@update-docs

This comment has been minimized.

Sign in to view
LukasHirt and others added 23 commits October 27, 2020 15:40
@LukasHirt
Show actual accordions
dc09a06
@LukasHirt
Fix switching of sharing sidebar panels
fb8070c
@LukasHirt
Fix position of sharing sidebar panels
bf5f586
@LukasHirt
Remove leftover log
4122202
@LukasHirt
Fix quick action
7cee845
@kulmann
Fix sidebar panel on indicators
d76a4a5
@LukasHirt
Update ODS
3e27e93
@LukasHirt
Add icons to accordions
33906ce
@LukasHirt
Fix indicators
27e8b02
@kulmann
Use ODS 1.14.0 for new control on expanded/collapsed state
d4eccc4
@kulmann
Merge remote-tracking branch 'origin/master' into sidebar-accordions
44ffdf2
@kulmann
Use new icon for file versions accordion item
7fea166
@kulmann
Rename rightSidebar to appSidebar and adjust tests
525c734
@kulmann
Set versions as first accordion item again for now
69b9f8e
@kulmann
Fix selector for sidebar accordion triggers
d99cabf
@kulmann
Click accordion items only when they are closed
f61bab4
@kulmann
Check in more places if accordion item already open
c354020
@kulmann
Fix a test
553bbba
@kulmann
Fix broken external accordion controls
e02e964
@kulmann
Fix more tests
5743aa1
@kulmann
Fix expanded accordion id on null value
4ff3e33
@kulmann
Add test about invisible sidebar after closing
bd816f3 
And fix the check for visible/invisible sidebar and accordion panels
@kulmann
Changelog
26fc8da
@kulmann kulmann self-requested a review October 29, 2020 15:23
@kulmann kulmann marked this pull request as ready for review October 29, 2020 15:23
@kulmann kulmann changed the title WIP Switch to accordions in the sidebar Switch to accordions in the sidebar Oct 29, 2020
@kulmann kulmann mentioned this pull request Oct 29, 2020
Closed
@kulmann kulmann merged commit 6632db9 into master Oct 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the sidebar-accordions branch October 29, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasHirt @kulmann