update templates to use new protobuf api #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google introduced a new protobuf API: https://blog.golang.org/protobuf-apiv2 causing the current release of staticckeck to barf on several related packages: dominikh/go-tools#732 ... fixed in dominikh/go-tools@7e758a3 Currently, protoc-gen-microweb uses `github.com/golang/protobuf/jsonpb` which is still reported: ``` make staticcheck go run honnef.co/go/tools/cmd/staticcheck -tags '' github.com/owncloud/ocis-hello/cmd/ocis-hello github.com/owncloud/ocis-hello/pkg/assets github.com/owncloud/ocis-hello/pkg/command github.com/owncloud/ocis-hello/pkg/config github.com/owncloud/ocis-hello/pkg/flagset github.com/owncloud/ocis-hello/pkg/metrics github.com/owncloud/ocis-hello/pkg/proto/v0 github.com/owncloud/ocis-hello/pkg/server/debug github.com/owncloud/ocis-hello/pkg/server/grpc github.com/owncloud/ocis-hello/pkg/server/http github.com/owncloud/ocis-hello/pkg/service/v0 github.com/owncloud/ocis-hello/pkg/version pkg/proto/v0/hello.pb.micro.go:8:2: package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead. (SA1019) pkg/proto/v0/hello.pb.web.go:14:2: package github.com/golang/protobuf/jsonpb is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019) exit status 1 make: *** [Makefile:73: staticcheck] Fehler 1 ``` This PR should update the dependency.
|
hm this also needs an update to go.mod |
|
Maybe you want to transfer it to the ownCloud org? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google introduced a new protobuf API: https://blog.golang.org/protobuf-apiv2 causing the current release of staticckeck to barf on several related packages: dominikh/go-tools#732 ... fixed in dominikh/go-tools@7e758a3
Currently, protoc-gen-microweb uses
github.com/golang/protobuf/jsonpbwhich is still reported:This PR should update the dependency.