Tests for aborted downloads #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @moscicki, @nickvergessen and @schnidrig to be potential reviewers. |
This was referenced Dec 2, 2016
Closed
|
Tested passed => this is wrong. Tests must fail on PHP 7 @DeepDiver1975 how are the PHP 7 smashbox tests going ? |
|
Please review @jvillafanez @DeepDiver1975 @VicDeo @mrow4a, even if tests pass now I think it's fine to merge them. Once the PHP 7 env is there it will reveal the failure and then maybe people will be more interested in reviewing the matching fixes. |
VicDeo
reviewed
Jan 13, 2017
|
|
||
| res = requests.get(log_url) | ||
|
|
||
| fatal_check(res.status_code == 200, 'Could not download the log file from the server, statuc code %i' % res.status_code) |
|
@PVince81 looks good except a typo 👍 |
added 2 commits
January 13, 2017 17:02
In some envs this causes log entries to appear
PVince81
force-pushed
the
abortion-tests
branch
from
821d3a0
to
93404b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test to reproduce the issue owncloud/core#22370 with PHP 7.
The only way to check if the issue occurs is by scraping the log file, so I improved that routine to download the file through the private API instead of copying. (copying failed on my envs due to different perms...)
Running this test is currently able to reproduce the issue after 10-15 iterations.
@DeepDiver1975 I think it would be fine to have a single executor for PHP 7 just for this one test, for now.
@jvillafanez @mrow4a please review