Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Adapt to new login design #232

Merged
merged 2 commits into from
Nov 3, 2021
Merged

[full-ci] Adapt to new login design #232

merged 2 commits into from
Nov 3, 2021

Conversation

hurradieweltgehtunter
Copy link
Contributor

@hurradieweltgehtunter hurradieweltgehtunter commented Jul 29, 2021 •
edited by AlexAndBear
Loading

fixes: #237
fixes: #231

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hurradieweltgehtunter hurradieweltgehtunter self-assigned this Jul 29, 2021
DeepDiver1975
DeepDiver1975 reviewed Jul 30, 2021
View reviewed changes
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 🔴

@hurradieweltgehtunter
Copy link
Contributor Author

I don't get it. Why is the drone build always killed?

@kiranparajuli589 kiranparajuli589 removed their request for review August 6, 2021 05:38
@JammingBen
Copy link
Contributor

@hurradieweltgehtunter This acceptance test fails: https://drone.owncloud.com/owncloud/twofactor_totp/1372/14/11

Fatal error: Call to a member function click() on null (Behat\Testwork\Call\Exception\FatalThrowableError)

The xpath for the submit action is wrong now: '//form/input[@type="submit"]' (see https://github.com/owncloud/twofactor_totp/blob/master/tests/acceptance/features/lib/VerificationPage.php#L35).

The other tests were probably cancelled due to this.

@AlexAndBear
Copy link

Will take care about the tests soon

@phil-davis phil-davis changed the title Adapt to new login design; [fulll-ci] Adapt to new login design Sep 29, 2021
@phil-davis phil-davis changed the title [fulll-ci] Adapt to new login design [full-ci] Adapt to new login design Sep 29, 2021
@phil-davis
Copy link
Contributor

I put full-ci in the PR title so that all test pipelines will run to completion. That will help to see all the tests that fail, in one pass.

@AlexAndBear AlexAndBear force-pushed the adapt-new-login-design branch 5 times, most recently from abf6522 to 16961f9 Compare September 29, 2021 08:10
@AlexAndBear
Copy link

@DeepDiver1975 @hurradieweltgehtunter CI should be green now, please review and merge, thx!
We might need to create a release issue as well

@prsnbrg
Copy link
Contributor

prsnbrg commented Oct 21, 2021

What is the current status?

phil-davis
phil-davis reviewed Oct 22, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@phil-davis phil-davis self-requested a review October 22, 2021 03:10
@phil-davis
Copy link
Contributor

I rebased to get up-to-date CI.
@hurradieweltgehtunter how do we move this forward?

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mmattel mmattel merged commit 2d09e8a into master Nov 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the adapt-new-login-design branch November 3, 2021 12:12
@phil-davis phil-davis mentioned this pull request Nov 3, 2021
Closed
44 tasks
@mmattel mmattel mentioned this pull request Nov 4, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@phil-davis phil-davis Awaiting requested review from phil-davis

@IljaN IljaN Awaiting requested review from IljaN

@JammingBen JammingBen Awaiting requested review from JammingBen

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@hurradieweltgehtunter hurradieweltgehtunter

Labels
3 - To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2FA login selection should be adapted to the new design Login not yet adapted to new design
8 participants
@hurradieweltgehtunter @CLAassistant @JammingBen @AlexAndBear @phil-davis @prsnbrg @DeepDiver1975 @mmattel