Use only 1 var in when matrix of drone #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=========================================
Coverage 35.64% 35.64%
Complexity 1340 1340
=========================================
Files 31 31
Lines 3785 3785
=========================================
Hits 1349 1349
Misses 2436 2436Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=========================================
Coverage 35.64% 35.64%
Complexity 1340 1340
=========================================
Files 31 31
Lines 3785 3785
=========================================
Hits 1349 1349
Misses 2436 2436Continue to review full report at Codecov.
|
tboerger
approved these changes
Aug 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new drone tries to auto-convert the old drone format. It seems that when there are multiple variables mentioned in the
whensection of a step, it is doing something in the auto-conversion that causes:linter: duplicate step namesI guess that it might be putting the step twice into the converted matrix.
The changes in this PR work-around the "feature".