Hotfix #447

[VicDeo]

if we want not to loose compatibility with 10.2

[DeepDiver1975]

When creating the command from xml the exact same stuff is done as what has explicitly been coded now.

There is still something wrong if the code patch is not fixing the issue

[PVince81]

not sure if the hotfix is really needed, considering that the original issue is with the apps/apps_external constellation for which there is a workaround: #447 (comment)

unless we want to send this patch to users and not release / merge it ?

[VicDeo]

@DeepDiver1975

When creating the command from xml the exact same stuff is done as what has explicitly been coded now.
There is still something wrong if the code patch is not fixing the issue

true.
but register_command is executed significantly later than info.xml is parsed. And when it is parsed wrong app.php is loaded. So the real fix is owncloud/core#36054

and this PR being a hotfix for the app is partially revert the changes from 360af33#diff-224bb875c5d3cfcd7621135069013242
This PR does exactly that. The same about authors - I just restored the original register_command.php, it had been not written by me.

[VicDeo]

@PVince81 I hadn't got any feedback so I decided to do both core fix for OC 10.3 and an app hotfix that will provide a seamless app upgrade experience for OC < 10.3 and potentially reduce number of support cases.
Surely it's up to management to decide whether hotfix is needed or not. :)

[PVince81]

not wanting to merge this. People should update to 10.3 when it's out.

if needed, this PR can be sent as patch.

@pmaier1 @cdamken FYI

[pmaier1]

Please make sure that there will be no issues in upgrading LDAP to 0.14.0, also on server versions below 10.3.

[PVince81]

@VicDeo please adjust based on comments

maybe also add a PHP comment somewhere as a note that the command is not in info.xml as a workaround, for the future.

we'll need to keep in mind to revert this again for the next LDAP app version 0.15.0 or later

[VicDeo]

@PVince81 updated, added fixme

addressed

[PVince81]

👍