Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor drone yml #454

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Refactor drone yml #454

merged 2 commits into from
Oct 11, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 11, 2019

  1. Move osixia/openldap to services section - because it should happily run as a service, rather than detached in the pipeline
  2. Remove obsolete NEED_USER_MANAGEMENT_APP from .drone.yml because the separate user_management app is no longer maintained/valid since core stable10 became master

I am cleaning this up before converting to drone starlark, to make sure that these changes work.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #454 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #454   +/-   ##
=========================================
  Coverage     35.64%   35.64%           
  Complexity     1340     1340           
=========================================
  Files            31       31           
  Lines          3785     3785           
=========================================
  Hits           1349     1349           
  Misses         2436     2436

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0057b82...55dc49b. Read the comment docs.

@phil-davis phil-davis merged commit 19205d7 into master Oct 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor-drone-yml branch October 11, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants