Initial drone starlark #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phil-davis
commented
Oct 11, 2019
•
phil-davis
commented
- code style
- phan
- phpunit
- integration tests (custom stuff)
- run user_ldap acceptance tests with "normal" LDAP
- run user_ldap acceptance tests with LDAPS
- run core acceptance tests
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
============================================
+ Coverage 35.64% 35.72% +0.08%
Complexity 1340 1340
============================================
Files 31 31
Lines 3785 3790 +5
============================================
+ Hits 1349 1354 +5
Misses 2436 2436
Continue to review full report at Codecov.
|
phil-davis
force-pushed
the
initial-drone-starlark
branch
2 times, most recently
from
4dda46c
to
370eba2
Compare
phil-davis
force-pushed
the
initial-drone-starlark
branch
2 times, most recently
from
4cf2fec
to
3b24ccd
Compare
phil-davis
force-pushed
the
initial-drone-starlark
branch
from
3b24ccd
to
95af949
Compare
individual-it
approved these changes
Oct 14, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.