drone notify on failure #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: CI will fail right now, until the problem core tests have been adjusted/skipped and merged. |
phil-davis
force-pushed
the
drone-notify-on-failure
branch
from
ab76fc4
to
6219e99
Compare
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
=========================================
Coverage 35.72% 35.72%
Complexity 1340 1340
=========================================
Files 31 31
Lines 3790 3790
=========================================
Hits 1354 1354
Misses 2436 2436Continue to review full report at Codecov.
|
individual-it
approved these changes
Oct 18, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like owncloud/activity#794
If a nightly build has failure, then nothing is being reported in rocketchat, because the pipelines stop once there is a failure. So the notify pipeline is never executed.
Adjust so that the notify pipeline will execute on both success and failure.