Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin behat/mink to 1.7.1 and update other acceptance test dependencies #532

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

phil-davis
Copy link
Contributor

From core issue owncloud/core#37113

behat/mink has to be pinned to 1.7.1 for now.

And while we are here, update the other acceptance test dependencies so they "document" the current minor releases that actually get used.

Note: symfony/translation 4.4 requires at least PHP 7.1.3 - that is why I changed platform php to 7.1.3

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #532 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #532   +/-   ##
=========================================
  Coverage     36.91%   36.91%           
  Complexity     1305     1305           
=========================================
  Files            31       31           
  Lines          3700     3700           
=========================================
  Hits           1366     1366           
  Misses         2334     2334

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff51de6...b17c50b. Read the comment docs.

@phil-davis phil-davis merged commit 84b7527 into master Mar 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the pin-behat-mink branch March 12, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants