-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change color of warning sign #678
Conversation
3a85de2
to
8a959a6
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The use of orange makes it better differenciateable from the red error block.
As an average admin, I would not know the specific use of orange here. The meaning here is "Everything is currently fine, but be cautious, when you enter these tabs" WND e.g. also uses orange in the admin interface -- there it means again something different (and non-guessable) Sorry for lobbying against this feature. I still fail to see a usecase that would outweight the possible confusion, that I can imagine. |
Total agree. |
I happily do another change if you let me know how it should be |
My view has not changed - remove the warning sign all together. The reasoning behind my view I described in a comment above. |
In adtion to #672