Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change color of warning sign #678

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

hurradieweltgehtunter
Copy link
Contributor

@hurradieweltgehtunter hurradieweltgehtunter commented Sep 1, 2021

In adtion to #672

grafik

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The use of orange makes it better differenciateable from the red error block.

@hurradieweltgehtunter hurradieweltgehtunter merged commit d49f18a into master Sep 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the change-warning-sign branch September 1, 2021 11:03
@pmaier1 pmaier1 mentioned this pull request Sep 13, 2021
51 tasks
@jnweiger
Copy link
Contributor

As an average admin, I would not know the specific use of orange here.

The meaning here is "Everything is currently fine, but be cautious, when you enter these tabs"
It is easily misunderstood as "Something needs your attention in this tab"

WND e.g. also uses orange in the admin interface -- there it means again something different (and non-guessable)

Sorry for lobbying against this feature. I still fail to see a usecase that would outweight the possible confusion, that I can imagine.

@voroyam
Copy link

voroyam commented Sep 13, 2021

As an average admin, I would not know the specific use of orange here.

The meaning here is "Everything is currently fine, but be cautious, when you enter these tabs"

It is easily misunderstood as "Something needs your attention in this tab"

WND e.g. also uses orange in the admin interface -- there it means again something different (and non-guessable)

Sorry for lobbying against this feature. I still fail to see a usecase that would outweight the possible confusion, that I can imagine.

Total agree.

@hurradieweltgehtunter
Copy link
Contributor Author

I happily do another change if you let me know how it should be

@voroyam
Copy link

voroyam commented Sep 15, 2021

My view has not changed - remove the warning sign all together. The reasoning behind my view I described in a comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants