Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Add search filter to shared with me (and align position across views) #10014

Closed
12 tasks
tbsbdr opened this issue Nov 20, 2023 · 2 comments · Fixed by #10033
Closed
12 tasks

[web] Add search filter to shared with me (and align position across views) #10014

tbsbdr opened this issue Nov 20, 2023 · 2 comments · Fixed by #10033
Assignees
Labels
Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Nov 20, 2023

Description

User Stories

  • As a user who is searching for a share, I want to filter within "shared with me" so that I can quickly find the share.

Value

  • improve file retrieval

Acceptance Criteria

  • Add Search filter to "shared with me", align to the right (same line as other, left aligned filters)
  • Files App > Spaces: Move search filter to the right for consistency
  • Admin settings > users: Move search filter to the right for consistency (same line as other, left aligned filters)
  • Admin settings > groups: Move search filter to the right for consistency
  • Admin settings > spaces: Move search filter to the right for consistency (same line as other, left aligned filters)
  • if viewport gets to small: break search field into next line

Definition of ready

  • Everybody needs to understand the value written in the user story
  • Acceptance criteria have to be defined
  • All dependencies of the user story need to be identified
  • Feature should be seen from an end user perspective
  • Story has to be estimated
  • Story points need to be less than 20

Definition of done

  • Functional requirements
    • Functionality described in the user story works
    • Acceptance criteria are fulfilled
  • Quality
    • Code review happened
    • CI is green (that includes new and existing automated tests)
    • Critical code received unit tests by the developer
  • Non-functional requirements
    • No sonar cloud issues

Visuals

screenshot_001969

@tbsbdr tbsbdr added the Type:Story User Story label Nov 20, 2023
@kulmann kulmann changed the title Add search filter to shared with me Add search filter to shared with me (and align position across views) Nov 21, 2023
@kulmann
Copy link
Member

kulmann commented Nov 21, 2023

@tbsbdr the screenshot suggests to put it on a different line than the left aligned filter chip... that was not intended, right? I would like to have the consistent pattern of one filter line with filter chips on the left and search field on the right.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Nov 21, 2023

should be on the same line, yes; scribble was not precise

@kulmann kulmann changed the title Add search filter to shared with me (and align position across views) [web] Add search filter to shared with me (and align position across views) Nov 21, 2023
@JammingBen JammingBen self-assigned this Nov 22, 2023
@JammingBen JammingBen mentioned this issue Nov 22, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants