Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page reload on search result page fires the search preview request #10200

Closed
kulmann opened this issue Dec 15, 2023 · 2 comments
Closed

Page reload on search result page fires the search preview request #10200

kulmann opened this issue Dec 15, 2023 · 2 comments
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Dec 15, 2023

Describe the bug

Being on the search result page and having a search term in the search input field fires the preview search request although the search dropdown doesn't show at all.

Steps to reproduce

  1. Enter any phrase into the search input field in the topbar
  2. Hit enter (= navigate to the search result page)
  3. Do a page reload
  4. Have a look at the network tab in the browser dev tools

Expected behavior

Only the full search request (REPORT to /dav/spaces) is executed. The preview search request (for the search input dropdown) only gets executed if the dropdown is supposed to become visible).

Actual behavior

The preview search request (the one that is executed upon opening/showing the search dropdown with the search result preview) gets executed as well, although the dropdown never shows at all.

@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Dec 15, 2023
@kulmann
Copy link
Member Author

kulmann commented Dec 15, 2023

@jacob-nv could you have a look at this?

@JammingBen
Copy link
Collaborator

Fixed via #10232.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants