Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No redirection to project space from notification #10397

Open
ScharfViktor opened this issue Jan 23, 2024 · 1 comment
Open

No redirection to project space from notification #10397

ScharfViktor opened this issue Jan 23, 2024 · 1 comment
Assignees
Labels
Priority:p3-medium Normal priority Status:Blocked Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ocis 5.1.0-prealpha+17b14ee78
web 8.0.0-rc.1

Steps:

  • admin creates space
  • admin adds member eintein
  • einstein open notification and click by space name

Actual: no redirect to Project space page. only after refreshing page

Screen.Recording.2024-01-23.at.17.24.30.mov
@ScharfViktor ScharfViktor added the Type:Bug Something isn't working label Jan 23, 2024
@JammingBen JammingBen added the Priority:p3-medium Normal priority label Jan 26, 2024
@JammingBen
Copy link
Collaborator

Good catch, a redirect to the space will only work after a page reload because then the space is being loaded by the runtime. In order to achieve that without a page reload we need to:

  • Check if the notification subject is of type "space shared" (or something like that)
  • If so, load the space by its id and add it to the list of loaded spaces (spaces store)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Status:Blocked Type:Bug Something isn't working
Projects
Status: blocked
Development

No branches or pull requests

2 participants