Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file download does not work on password protected public shares #1808

Closed
individual-it opened this issue Aug 16, 2019 · 4 comments · Fixed by #1895
Closed

file download does not work on password protected public shares #1808

individual-it opened this issue Aug 16, 2019 · 4 comments · Fixed by #1895
Assignees
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Topic:Security Pull requests that address a security vulnerability Type:Bug Something isn't working

Comments

@individual-it
Copy link
Member

Steps to reproduce

  1. create a public link share of a folder
  2. try to download a file from within that folder via public link

Expected behaviour

file should be downloaded

Actual behaviour

file cannot be downloaded

Client configuration

Browser:
Chrome

Logs

Browser log

Failed to load resource: the server responded with a status of 401 (Unauthorized)
core.bundle.js:75 Error: Unauthorized
    at core.bundle.js:75```
@individual-it individual-it added the Type:Bug Something isn't working label Aug 16, 2019
@DeepDiver1975 DeepDiver1975 added the Priority:p1-urgent Consider a hotfix release with only that fix label Aug 16, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Aug 16, 2019
@PVince81 PVince81 assigned VicDeo and unassigned DeepDiver1975 Aug 23, 2019
@PVince81 PVince81 added the Topic:Security Pull requests that address a security vulnerability label Aug 29, 2019
@VicDeo
Copy link
Member

VicDeo commented Sep 4, 2019

I can't login to view a password protected share at all...
When I enter an incorrect password I see a message in OC log. When the password is correct OC log is empty but the password popup still reappears.

@LukasHirt
Copy link
Contributor

Fixed in #1895 there was missing getter for the password which broke the authorization header. Needed to fix it in order for the other PR to fully work so I went ahead and did it there.

@LukasHirt
Copy link
Contributor

I can't login to view a password protected share at all...
When I enter an incorrect password I see a message in OC log. When the password is correct OC log is empty but the password popup still reappears.

@VicDeo Hmm, that is strange. Do you get some errors in the browser console? Or the network tab?

@LukasHirt LukasHirt mentioned this issue Sep 4, 2019
9 tasks
@VicDeo
Copy link
Member

VicDeo commented Sep 5, 2019

@LukasHirt I sorted it out already, I had a browser a naggy auth popup there that has nothing to do with a real auth page. The auth page was loaded after I clicked 'Cancel' in this popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Topic:Security Pull requests that address a security vulnerability Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants