Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display previews #276

Closed
3 of 9 tasks
PVince81 opened this issue Oct 12, 2018 · 12 comments
Closed
3 of 9 tasks

Display previews #276

PVince81 opened this issue Oct 12, 2018 · 12 comments
Labels
Category:Enhancement Add new functionality
Milestone

Comments

@PVince81
Copy link
Contributor

PVince81 commented Oct 12, 2018

@PVince81 PVince81 added the Category:Enhancement Add new functionality label Oct 12, 2018
@PVince81 PVince81 changed the title File details improvement Display previews Sep 24, 2019
@PVince81 PVince81 added this to the backlog milestone Sep 24, 2019
@DeepDiver1975
Copy link
Member

  • preview as thumbnail in the file list row

I wonder if this are really hard requirements for the frontend.

Cons:

  • small previews are almost impossible to view
  • heavy computation is required to create/deliver a lot of previews
  • personal opinion: they have never been usefull

@PVince81
Copy link
Contributor Author

Previews would start to become interesting once we get to implement a grid view of files (like gallery). Indeed the previews are rather small and even for pictures it doesn't show much.

@PVince81
Copy link
Contributor Author

The previews will be retrieved using the Webdav API like OC 10 has.

@PVince81
Copy link
Contributor Author

  • cannot send Bearer token through headers, so need to use fetch() API to retrieve the image data and then pack them into "data:" URLs
  • no cookies
  • not related to CORS

=> would require pre-signed URLs on OC 10 side

So far the current logic is ok for images but would require the pre-signed URL approach for videos.

@PVince81
Copy link
Contributor Author

@C0rby ^

@PVince81
Copy link
Contributor Author

to clarify, we already have an implementation that uses the preview endpoint in the media viewer app, and the approach above is what I described, see:

@PVince81
Copy link
Contributor Author

similar topic happens for downloads: #526 (comment)

for the scope of this sprint I suggest focusing only on bringing the same logic to the file list and its thumbnail retrieval.

later on we can look into pre-signed URL as part of https://github.com/owncloud/enterprise/issues/3912

@PVince81 PVince81 self-assigned this Mar 16, 2020
@PVince81
Copy link
Contributor Author

updated top post with some findings

@butonic
Copy link
Member

butonic commented Mar 30, 2020

server side merged with owncloud/ocis#157

@PVince81
Copy link
Contributor Author

PR for file previews in file list was merged: #3187

next up is adding a preview on top of the sidebar and solving the further points

@micbar micbar added this to Sprint Backlog in oCIS Sprint 20-9&10 via automation Apr 27, 2020
@micbar micbar moved this from Sprint Backlog to Input Next Sprint in oCIS Sprint 20-9&10 Apr 28, 2020
@micbar micbar removed this from Input Next Sprint in oCIS Sprint 20-9&10 Apr 28, 2020
@PVince81 PVince81 removed their assignment Sep 3, 2020
@pascalwengerter
Copy link
Contributor

We're now able to display thumbnails and do so for certain file types in the files list/table. There's also discussions about having larger previews in the sidebar or on a grid view, but that's a different story.

If further previews are needed please open a new ticket.

@phil-davis
Copy link
Contributor

Note: the last entries in expected-failures linked to this issue are removed in PR #5787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

No branches or pull requests

5 participants