Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared with column in "Shared with others" should contain multiple users #2924

Closed
PVince81 opened this issue Jan 28, 2020 · 4 comments · Fixed by #3049
Closed

Shared with column in "Shared with others" should contain multiple users #2924

PVince81 opened this issue Jan 28, 2020 · 4 comments · Fixed by #3049
Assignees
Labels
Topic:good-first-issue beginner friendly task Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

Steps

  1. Create three users "Alice", "Bob" and "Charlie"
  2. Login as "Alice"
  3. Share a folder "test" with both "Bob" and "Charlie"
  4. Open the "Shared with others" panel
  5. Look at the "Shared with" column for the "test" folder

Expected result

Both "Bob" and "Charlie" appear there, separated with a comma.
If more than three users or groups, show an ellipsis for the fourth one (check product requirement there)

Actual result

Only "Charlie" appears.

The network response does contain two entries so it's a frontend issue.

@pmaier1 FYI

@PVince81
Copy link
Contributor Author

PR here: #3049

@PVince81
Copy link
Contributor Author

I went a bit overboard... I've noticed that link shares are now also included so I went a bit further and tried to add some distinction.

In my first attempt (the before last commit), shows share indicators:
image

Please note that we cannot show indirect shares there due to performance reasons.

And another further attempt (last commit) with the collaborator list:
image

I don't think I'll go further there but we can use this as input for further designs.
As the goal was to just fix the list of collaborators, I might split this PR into "current fix" and "future stuff".

@pmaier1 @LukasHirt

@LukasHirt
Copy link
Contributor

It feels a bit weird seeing the link in collaborators column but I understand that it needs to be there 🙈

@PVince81
Copy link
Contributor Author

next iteration here, looks a bit better now with avatars: #3049 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic:good-first-issue beginner friendly task Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants