Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filter button #2971

Closed
5 tasks
PVince81 opened this issue Feb 5, 2020 · 1 comment · Fixed by #2972
Closed
5 tasks

Remove filter button #2971

PVince81 opened this issue Feb 5, 2020 · 1 comment · Fixed by #2972
Assignees
Labels

Comments

@PVince81
Copy link
Contributor

PVince81 commented Feb 5, 2020

The filter button on the top right is confusing and needs to be reworked.

In the meantime we (with @pmaier1) decided to remove it altogether for the Phoenix MVP milestone.

The filter button contains the following pieces:

  • only show files or folders: there was never a requirement for this, we should remove this completely
  • checkbox for showing hidden files: for now we make it default to true
  • search box for the local folder: users should use the search in the top bar. In general we'll likely want to have only a single search box and have the search results split between "locally visible entries" and "resources in other folders" like we had in OC 10.

Tasks

  • Remove filter button on the top right
  • Make hidden files visible by default
  • Raise tickets for the proper design + implementation
    • search box results for local folder
    • checkbox for hidden files
@PVince81 PVince81 added the Category:Enhancement Add new functionality label Feb 5, 2020
@PVince81 PVince81 self-assigned this Feb 5, 2020
@PVince81 PVince81 mentioned this issue Feb 5, 2020
9 tasks
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 5, 2020

PR here #2972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant