Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share indicators appear delayed #2973

Closed
PVince81 opened this issue Feb 5, 2020 · 3 comments · Fixed by #3213
Closed

Share indicators appear delayed #2973

PVince81 opened this issue Feb 5, 2020 · 3 comments · Fixed by #3213
Assignees
Labels
Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

PVince81 commented Feb 5, 2020

Steps

  1. Create a folder "test"
  2. Share "test" with link or a collaborator
  3. Refresh the page and observe closely the progress bar and the indicators

Expected result

Indicator appears immediately after the progress bar disappears.

Actual result

First the progress bar disappears, the file list appears, and then after a second the share indicator appears

Version

v0.3.0

This is a regression as it used to work when I worked with sharing indicators.
The code that loads the share indicators was designed to happen while the progress bar is still shown. In other words, the progress bar should show as long as neither file list nor indicators have finished loading.

Could this be related to your changes @LukasHirt ?

cc @kulmann if you want to look into this

@PVince81 PVince81 added the Type:Bug Something isn't working label Feb 5, 2020
@LukasHirt
Copy link
Contributor

It probably is related to my change (#2928). The component with the indicators is now separated. The load process might need to be adjusted because now indicators wait for the list to be loaded which can cause the delay.

I'd maybe suggest moving the display logic of files list into components where it's used instead of FilesList component.

@Julian1998 Julian1998 self-assigned this Feb 27, 2020
@PVince81
Copy link
Contributor Author

@Julian1998 any update ? Please unassign if you don't intend working on this as you're blocking other people who might want to take over. Thanks.

@Julian1998
Copy link
Contributor

@PVince81 Still working on it.... just need to figure out some vue things first.
As discussed with @LukasHirt I need to seperate the share indicator loading process from the file list loading process.... but it is not really synced then. I am searching for a workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants