Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(incorrectly) limited link roles in personal space #7506

Closed
kulmann opened this issue Aug 22, 2022 · 0 comments · Fixed by #7580
Closed

(incorrectly) limited link roles in personal space #7506

kulmann opened this issue Aug 22, 2022 · 0 comments · Fixed by #7580
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Aug 22, 2022

Steps to reproduce

  1. Log in as einstein
  2. Create a folder "from-einstein"
  3. Share folder "from-einstein" with marie
  4. Log in as marie
  5. Visit "Shared with me" page
  6. Accept "from-einstein" share
  7. Create a quick link with viewer permissions (= default) on "from-einstein" (e.g. via right-click context menu)
  8. Navigate to "Personal" space (still as marie)
  9. Create a folder "my-stuff"
  10. Create quick link on "my-stuff"
  11. Try to edit the role of the quicklink on "my-stuff"

Expected behaviour

As "my-stuff" belongs to marie, all possible roles need to be available

Actual behaviour

Only the "Viewer" role is available

Bug analysis

FileLinks.vue has a computed prop share which only ever picks the first incoming share it finds in the root of the shares tree. This is wrong because the root contains more share entities than just the ones related to the given folder "my-stuff", in this case also the reshared folder "from-einstein". Because of that the link from (10) is identified as a reshare, which is wrong.

@kulmann kulmann added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker GA-Blocker labels Aug 22, 2022
@kulmann kulmann added this to Qualification in Web Support Board via automation Aug 22, 2022
@kulmann kulmann moved this from Qualification to Bugs Prio 2 in Web Support Board Aug 22, 2022
@kulmann kulmann added this to the 2.0.0 General Availability milestone Aug 22, 2022
@JammingBen JammingBen self-assigned this Sep 2, 2022
Web Support Board automation moved this from Bugs Prio 2 to Done Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants