Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve private links in oCIS #7707

Closed
kulmann opened this issue Sep 29, 2022 · 0 comments · Fixed by #7769
Closed

Resolve private links in oCIS #7707

kulmann opened this issue Sep 29, 2022 · 0 comments · Fixed by #7769
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Sep 29, 2022

Description

oCIS is now capable of announcing private links in PROPFINDs. The web ui needs to be able to resolve those. Clients (e.g. Desktop, or back-buttons in external editors) need private links in order to open the files app of the web ui, resolved and navigated to the file id from the private link.

Reasoning for private links instead of internal links

While internal links achieve the same goal, the private link is constructed by string concatenation in a defined format. The internal link has to be created first. If e.g. the Desktop client would need to create an internal link backend side, only to let the user navigate to the file in the web ui, we'd create a lot of link shares that would otherwise not be needed at all.

In contrast to oc10 where some people are used to copying private links from the web ui, we don't want to show the copy button in the web ui for oCIS. There is a capability (planned, ETA today or tomorrow) to disable the button in the ui.

Expected behaviour

Resolve private links to files in any space or share.

Actual behaviour

Private links to files in the personal space do seem to resolve. Resolving files in other spaces fails with an error. (at least in #7430 )

@kulmann kulmann added Type:Bug Something isn't working Priority:p1-urgent Consider a hotfix release with only that fix GA-Blocker labels Sep 29, 2022
@kulmann kulmann added this to Qualification in Web Support Board via automation Sep 29, 2022
@kulmann kulmann added this to the 2.0.0 General Availability milestone Sep 29, 2022
@kulmann kulmann moved this from Qualification to Bugs Prio 1 in Web Support Board Sep 29, 2022
Web Support Board automation moved this from Bugs Prio 1 to Done Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant