New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why include mosquitto in Docker? #13
Comments
Contributions accepted. |
I've created a docker setup without MQTT and without docker Regards, |
I think you should create a pull request ;) A nice feature could be to create two images, a base recorderd image (only the recorder) and an extended recorderd-mosquitto (buldled with mosquitto and its config) or better an example docker compose file |
I will gladly repeat myself: we accept contributions and pull requests. |
I think the base docker image should look like
|
Here's a
|
I started to work on this here: My Idea is the following:
What needs to be done:
What I would like to know:
|
It will not be ignored or rejected. If it works well and is well documented, we will gladly take it. |
@deisi I am very much interested in the whole thing. I have a dedicated mosquitto running, mostly for smart home stuff, so the "official" image with the embedded mqtt broker is not suitable for me. I'll check your repo and try to get it running. |
I updated the documentation a little. I would be glad if I get some feedback https://github.com/deisi/docker-ot-recorder |
@deisi for those of us (i.e. myself) who are not very proficient in things Docker, it would be good if you could elaborate a bit on the
|
You cannot specifically say where the data is actually stored since Docker volumes are created somewhere in A host directory can very well passed as |
@jpmens To understand Now the reason why I didn't add much more to this section is that the user usually doesn't have to care. If you use the Sry for the many words. |
until things go wrong :) You're right in that being how docker works, but I still think it's important to know what goes on under the hood. Both your explanations (@simonszu and @deisi) are good, and I'd like to see them merged together into, at least, an additional page explaning a bit of the "why you should do this in this particular way". |
As far as I'm concerned, you can submit a PR with your changes. Please separate (if they can be separated) the two installation methods in the README (ie. via |
Okay, how should I do it? Should I make a PR for the I think |
Please make the PR against this project. I will then asap rename this repository to |
PR has been submitted in #20 |
I wanted to run recorderd next to my Mosquitto instance but it seems they are both included in the docker image of recorderd.
Running multiple services in the same container is against Docker standards, the best way to run both is with a docker-compose configuration.
Can you provide a docker image without Mosquitto?
The text was updated successfully, but these errors were encountered: