-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heads up: repository now renamed to docker-recorder #21
Comments
@jpmens I think you shoul recreate the Docker repository, in order to tie it to the github repo. you should see something like this: You probably need to relink your github account (since the last time I've used it it needed to be relinked as they changed the method) After choosing github org after that you can create the repo, and under builds there are ways to auto trigger the build on push to the github record or manually. |
That doesn't seem to work any more, at least not with the Not a problem for now, as I can Any suggestion as to tagging? |
ah! I should have probably noticed since I'm in the owntracks github organization that's an unfortunate change.
Yes I think this should work, for now.
I would just go with |
|
A disadvantage of Would it not be clever to match the tag to the Recorder version? Or is that just not done? |
As it is the recorder version that gets installed in the docker image is defined by Line 10 in 92e4801
That is used later to download the relevant release from github and build from the sources. ps: that can be overridden in build phase via environment variables but that isn't the point here. |
Also possible, however we should have an idea what happens if the docker container changes for what ever reason but not the recorder code base. |
Would
|
👍 |
Done. |
... as discussed in #13
The text was updated successfully, but these errors were encountered: