Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up: repository now renamed to docker-recorder #21

Closed
jpmens opened this issue Jan 9, 2019 · 11 comments
Closed

Heads up: repository now renamed to docker-recorder #21

jpmens opened this issue Jan 9, 2019 · 11 comments

Comments

@jpmens
Copy link
Member

jpmens commented Jan 9, 2019

... as discussed in #13

@jpmens
Copy link
Member Author

jpmens commented Jan 9, 2019

@deisi and/or @juzam I think I now need a bit of help on how to replace the image on docker hub. I've created a new owntracks/recorder and the site looks like this:

jmbp-4946

How do I continue?

@juzam
Copy link
Collaborator

juzam commented Jan 9, 2019

@jpmens I think you shoul recreate the Docker repository, in order to tie it to the github repo. you should see something like this:

image

You probably need to relink your github account (since the last time I've used it it needed to be relinked as they changed the method)

After choosing github org onwntracks you should select docker-recorder

after that you can create the repo, and under builds there are ways to auto trigger the build on push to the github record or manually.

@jpmens
Copy link
Member Author

jpmens commented Jan 9, 2019

That doesn't seem to work any more, at least not with the owntracks organization; it links to my (jpmens) github account only and can thus not find the OwnTracks repositories.

Not a problem for now, as I can docker push owntracks/recorder from the CLI which, I assume, amounts to the same.

Any suggestion as to tagging?

@juzam
Copy link
Collaborator

juzam commented Jan 9, 2019

That doesn't seem to work any more, at least not with the owntracks organization; it links to my (jpmens) github account only and can thus not find the OwnTracks repositories.

ah! I should have probably noticed since I'm in the owntracks github organization that's an unfortunate change.

Not a problem for now, as I can docker push owntracks/recorder from the CLI which, I assume, amounts to the same.

Yes I think this should work, for now.

Any suggestion as to tagging?

I would just go with latest and 1.0 for a start.

@deisi
Copy link
Contributor

deisi commented Jan 9, 2019

latest and 1.0 sound good

@jpmens
Copy link
Member Author

jpmens commented Jan 9, 2019

A disadvantage of 1.0 is that we can't tell from "outside" which version of Recorder is actually in there (I'm thinking of "support queries").

Would it not be clever to match the tag to the Recorder version? Or is that just not done?

@juzam
Copy link
Collaborator

juzam commented Jan 9, 2019

As it is the recorder version that gets installed in the docker image is defined by

ENV VERSION=0.8.0

That is used later to download the relevant release from github and build from the sources.
So it could be sensible to use that tag (that has to be kept up to date with the Recorder version)

ps: that can be overridden in build phase via environment variables but that isn't the point here.

@deisi
Copy link
Contributor

deisi commented Jan 9, 2019

Also possible, however we should have an idea what happens if the docker container changes for what ever reason but not the recorder code base.

@jpmens
Copy link
Member Author

jpmens commented Jan 9, 2019

Would <RECORDER_VERSION>-<docker-container> make sense?

0.8.0-1    current recorder, first docker image
0.8.0-2    current recoder, second docker image
0.8.1-1    next recorder version (maybe), first docker image for that version

@deisi
Copy link
Contributor

deisi commented Jan 9, 2019

👍

@jpmens
Copy link
Member Author

jpmens commented Jan 10, 2019

Done.

@jpmens jpmens closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants