Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include precompiled dist/ in releases #90

Closed
atlib77 opened this issue Sep 28, 2022 · 4 comments · Fixed by #114
Closed

Include precompiled dist/ in releases #90

atlib77 opened this issue Sep 28, 2022 · 4 comments · Fixed by #114
Labels
Status: Done Feature has been implemented, bug fixed, question answered etc. Type: Enhancement Improve something that's already there

Comments

@atlib77
Copy link

atlib77 commented Sep 28, 2022

Any reason not to? Would make it a lot simpler for most to install the Frontend on web server
@linusg
Copy link
Member

linusg commented Sep 28, 2022

If you make a PR to automate this, sure :)

@atlib77
Copy link
Author

atlib77 commented Sep 28, 2022

:) how are you currently deploying the releases? Fully manually?
I guess enhancing the build github action to include a deployment shouldn't be more then a few lines. Wouldn't you do it like that?

@linusg
Copy link
Member

linusg commented May 23, 2023

Via the GitHub UI, which in turn creates a git tag (considered a "release"), which in turn triggers this GitHub action for the Docker image build:

frontend/.github/workflows/docker.yml

Lines 12 to 16 in 9bb2edb

release:
types: [published]
branches: main
tags:
- v*

@jpmens
Copy link
Member

jpmens commented Feb 4, 2024

We'd be interested in dist/ releases as well for Frontend installation in quicksetup.

@jpmens jpmens mentioned this issue Feb 4, 2024
Open
@jpmens jpmens mentioned this issue Feb 26, 2024
Closed
@abaumg abaumg mentioned this issue Apr 30, 2024
Merged
@linusg linusg added Type: Enhancement Improve something that's already there Status: Done Feature has been implemented, bug fixed, question answered etc. labels Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Done Feature has been implemented, bug fixed, question answered etc. Type: Enhancement Improve something that's already there
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add action for uploading dist/ on release abaumg/frontend
3 participants
@jpmens @linusg @atlib77