Add action for uploading dist/ on release #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpmens is this sufficient for your use case or do you have any suggestions? I for one would prefer a compressed tarball over zip but this might be fine, too. |
|
@linusg the way I understand the code is that the zip file would land at https://github.com/owntracks/frontend/releases Sounds ok to me. I personally would have also preferred a compressed tarball, but zip works as easily. |
|
Let's go with this then, we can always change it later :) I have no idea how to test this but merging and tagging another release. |
linusg
changed the title
|
We can easily create multiple assets in the GitHub action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #90 by adding a GitHub Action which runs whenever a new release was created. It creates a build, zips it and adds the zip file to the previously created release.
Feedback is welcome.