Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker dev setup #25

Merged
merged 14 commits into from
Apr 4, 2016
Merged

Docker dev setup #25

merged 14 commits into from
Apr 4, 2016

Conversation

t0mk
Copy link
Collaborator

@t0mk t0mk commented Mar 29, 2016

My basic Docker dev setup. Code is host-mounted. Cron runs in the same container as Django. Simple scirpt in web container startup waits for postgres, and then attempts to do what you suggest to initialize in the readme.

Merge if you like. Let me know if you think there's sth to fix or improve.

@owocki
Copy link
Owner

owocki commented Mar 29, 2016

Thanks for the PR Tom. I'm going to test this out tonight on my home machine.

@owocki
Copy link
Owner

owocki commented Mar 30, 2016

having some trouble getting this up & running locally via docker (probably due to my docker-noob-ness). Have you requested an invite to our slack? I'd like to hear how you've been using the repo, and also talk through an issue or two I'm having.

#23

@Snipa22
Copy link
Collaborator

Snipa22 commented Apr 1, 2016

This works fine on my systems for development.

The suggestions I'd make are as follows:
Add examples for the .env and the docker-compose.yml files, then put them into the .gitignore, so we can do local customization to these easier.

@owocki
Copy link
Owner

owocki commented Apr 3, 2016

@t0mk what do you think? if you want to make those changes, and then fix the merge conflicts, Ill happily merge this into the repo.

@t0mk
Copy link
Collaborator Author

t0mk commented Apr 4, 2016

I'll do that later today!

@t0mk
Copy link
Collaborator Author

t0mk commented Apr 4, 2016

Done.

@t0mk
Copy link
Collaborator Author

t0mk commented Apr 4, 2016

Fixed some issues, now it's alright.

simplejson==3.8.2
Cython==0.23.5
sklearn==0.0
scipy
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've always specified pip versions for my teammates. helps eliminate differences in our testing / production environments. was this change intentional? if so, why is it good not to specify versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was intentional - the pip call doesn't succeed with the versions specified. The numpy setup.py failed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe there are some apt-get dependancies here too. need to find/ document those.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt-get deps are not necessary so please don't bother. It's built based on official Python 2.7 image, which is some sort of debian.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem while building was that that version of scipy was not possible to be built with the newest numpy (and I didn't know which version of numpy you had, because it's not in the requirements). So I just dropped all the versions (except for Django because that broke down the startup) and build it. Now, I think I found the proper version of numpy so let's see.

It's not instant to see if the things work out, because install of numpy and then scipy takes some time (~20 miuntes on my crappy laptop).

@owocki
Copy link
Owner

owocki commented Apr 4, 2016

erg, some recent PR merges have created merge conflicts.

@t0mk @Snipa22 i've given you push access to the repository, so you (should) now have the ability to merge changes to master.

for this PR, just need to correct the merge conflicts. for future PRs, my only ask to start is that we all get aligned on changes to master via a pull request.

@t0mk t0mk merged commit 30cb0de into owocki:master Apr 4, 2016
@NDuma
Copy link

NDuma commented Apr 4, 2016

What do I need to do to load this into cloud.docker.com with Digital Ocean?
Or is AWS or Azure (other) a better way to go?

@owocki
Copy link
Owner

owocki commented Apr 4, 2016

good question .. might be good to open up an issue and discuss there.

@owocki
Copy link
Owner

owocki commented Apr 4, 2016

i'd bet with a little googling you could come up with an approach that is 80% of the way there.

@NDuma
Copy link

NDuma commented Apr 5, 2016

I'm on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants