fix Signature.prototype.hasDefinedHashtype #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajp8164
approved these changes
Oct 7, 2017
niahmiah
force-pushed
the
hasDefinedHashTypeFix
branch
from
b597694
to
0934cda
Compare
ajp8164
reviewed
Nov 6, 2017
lib/crypto/signature.js
Outdated
| @@ -293,7 +293,11 @@ Signature.prototype.hasDefinedHashtype = function() { | |||
| } | |||
| // accept with or without Signature.SIGHASH_ANYONECANPAY by ignoring the bit | |||
| var temp = this.nhashtype & ~Signature.SIGHASH_ANYONECANPAY; | |||
| if (temp < (Signature.SIGHASH_ALL|Signature.SIGHASH_FORKID) || temp > (Signature.SIGHASH_SINGLE|Signature.SIGHASH_FORKID)) { | |||
|
|
|||
| // accept with or without Signature.SIGHASH_FORKID by ignoring it too | |||
There was a problem hiding this comment.
Why does this bit have to be ignored? Wouldn't FORKID necessarily be present all the time?
|
closing after discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating issues with bch-channel tests, ran into this. Seems wrong. Let's discuss.