-
-
Notifications
You must be signed in to change notification settings - Fork 71
How to regenerate the onnx tests? #128
Comments
There is a By now, there is no plan to update the tests periodically, maybe we should think about it. |
I can do that, maybe we can abstract everything inside a Docker image. Didn't knew that I had to pull the |
I apologize, I should have written the command line to generate the tests. Here it is:
You can replace the wildcard by an operator name, and get rid of the I don't think we need docker in this case. Maybe we can just mention that in a readme somewhere. |
Never mind the Docker, I was thinking in another stuff and got confused 😅 I didn't found any thing related to what version of
This is the kind of stuff that we don't need to run everytime, but when we do, it must be "reproducible" and easy as possible. My plan is to use something like go-git to download the Sounds good to you @owulveryck? |
Sounds like a very good idea. The problem is that the repository will have one more dependency. But by now, we can deal with it I guess. Besides that, what you say is a good point about the version onnx-go should support. I really like the idea of the Go compatibility, but I have no idea of the effort needed to maintain such compatibility policy. I'd rather evaluate the risk before claiming it. PS: Sorry about the spam (I mean the previous comment I have deleted), the first reply was off-topic, I misread your comment |
We already have this dependency, the only thing that I'm proposing is to embrace and automate to make it easier to others. And it will work just like it's working today, the generated tests will be committed. Being new in a project is really good to detect this kind of pain points.
The lack of knowledge on the supported ONNX version is bad for everyone, to the users that are trying to use the package and for us as we have a moving target on the tests. For now I think I'll point to the last release and later on when we have a more clear vision of what the project need to support or not we can revisit this point.
Don't worry 😄 |
We may also have a look at https://arxiv.org/abs/1906.05676v1 |
Is your feature request related to a problem? Please describe.
I've updated the test template and now I need to regenerate the tests.
Describe the solution you'd like
Would be nice to have a command like
make gen-tests
or something likego generate ./...
that could run those commands.The text was updated successfully, but these errors were encountered: