Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code fragments need comments #2

Closed
ToonTalk opened this issue Aug 8, 2016 · 1 comment
Closed

Code fragments need comments #2

ToonTalk opened this issue Aug 8, 2016 · 1 comment

Comments

@ToonTalk
Copy link
Contributor

ToonTalk commented Aug 8, 2016

But not too many. E.g. in http://ox-it.github.io/LiveData_htmlwidgets/charts/BarCharts/ there is

desktopItems <- read.csv(file = "https://ndownloader.figshare.com/files/5360960")
knitr::kable(head(desktopItems))

I think the first line is self-evident so I recommend changing it to

desktopItems <- read.csv(file = "https://ndownloader.figshare.com/files/5360960")
// after reading the CSV file blah blah blah ...
knitr::kable(head(desktopItems))
@charliejhadley charliejhadley mentioned this issue Sep 12, 2016
Closed
@charliejhadley
Copy link
Contributor

The initial concern has been addressed, regarding kable. #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ToonTalk @charliejhadley