This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When determining which roles are defined for role-based access, only consider those that grant READ access. This exists because it is possible to define a role which doesn't grant read access but will still consider this as role-based access. This currently blocks adding role-based access and removing it.
- Loading branch information
4e5b24b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite your full commit message, why should we only return roles that can read resources?
4e5b24b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the discussion in the room there is already code in BaseContentService that does these permission checks and this is just bringing this method "into line".