Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cargo pkg version parsing #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix cargo pkg version parsing #18

wants to merge 1 commit into from

Conversation

therishidesai
Copy link

The setCargoCommonBuildEnv function in builder-common.sh doesn't properly use BASH_REMATCH to parse the version number. The 0 index of BASH_REMATCH is the whole string so the CARGO_PKG_VERSION_MAJOR was failing with an InvalidDigit Error. I noticed this when trying to package the ffmpeg-sys-next crate using nocargo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@therishidesai