Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dialog element to manage focus inside modals #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sivakusayan
Copy link
Contributor

This should close #89. We're going to rely on the browsers' implementation of the <dialog> element instead of trying to do our own focus handling. There is still the issue of the dialog's close "X" button not having a focus outline, but that's pre-existing and can perhaps be resolved in a separate PR (mostly because I'm not sure if ya'll have any strong opinions on what the focus outline should look like).

As an aside, this is the first time I'm writing any Clojure code at all that isn't just copy-pasting code into a REPL from some book, so don't be shy about feedback 🙂

@borkdude
Copy link
Collaborator

borkdude commented Oct 9, 2023

@oxalorg ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider better focus handling when showing a dialog
2 participants