Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#50 Update to <pre> font size to be consistent with <code> #52

Merged
merged 3 commits into from
Feb 5, 2022
Merged

#50 Update to <pre> font size to be consistent with <code> #52

merged 3 commits into from
Feb 5, 2022

Conversation

hedgecox
Copy link
Contributor

@hedgecox hedgecox commented Oct 3, 2020

#50

@oxalorg
Copy link
Owner

oxalorg commented Oct 3, 2020

@hedgecox Thanks for the PR, I think this will cause code tags which are inside pre tag to have their font reduced twice as we are using ems.

Can you please confirm if you have tested for this?

@hedgecox
Copy link
Contributor Author

hedgecox commented Oct 3, 2020

@oxalorg Good catch, I've updated the pre > code rule to ensure this rule doesn't nest any further.

@oxalorg oxalorg merged commit 1f2f312 into oxalorg:master Feb 5, 2022
@oxalorg
Copy link
Owner

oxalorg commented Feb 5, 2022

@hedgecox Apologies don't know why I forgot to merge this nice PR.

@oxalorg oxalorg mentioned this pull request Feb 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hedgecox @oxalorg