Unexpected result NotFound('node:http') with imports field and builtins: true option

[hyf0]

import fs from '#fs'
import http from '#http'
fs.readFileSync()
http.createServer()

{
  "imports": {
    "#fs": {
      "node": "fs",
      "default": "./empty.js"
    },
    "#http": {
      "node": "node:http",
      "default": "./empty.js"
    }
  }
}

While resolving #fs, oxc-resolver correctly maps #fs to fs. Then oxc-resolver returns NotFound("fs"), which is also correct with builtins: false.

However, with builtin: true, oxc-resolver should return Builtin('fs') or Builtins('node:http').

[hyf0]

Rolldown currently will handles Builtin(xxx) specially, which is treating xxx as a valid external module while targeting node platform. But the behavior said above makes rolldown can't handle builtin node modules right due to that oxc-resolver return NotFound.

Rolldown treats NotFound as a invalid case and will throw a warning. So it will be better to make oxc-resolver also return Builtin for the above described behavior to be more consistency for resolving builtin node modules with builtin: true.

[ematipico]

However, with builtin: true, oxc-resolver should return Builtin('fs') or Builtins('node:http').

I don't understand one thing though: what's the issue? Why should it return this result? What does it return instead?

[hyf0]

However, with builtin: true, oxc-resolver should return Builtin('fs') or Builtins('node:http').

I don't understand one thing though: what's the issue? Why should it return this result? What does it return instead?

For resolving #http with ResolveOptions#builtin: true, oxc-resolver should return Err(ResolveError::Builtin('node:http')) instead of Err(ResolveError::NotFound).