feat: substitute path that starts with ${configDir}/ in tsconfig.compilerOptions.paths
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boshen
changed the title
${configDir}/ in tsconfig.co…${configDir}/ in tsconfig.compilerOptions.paths
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 94.94% 95.01% +0.06%
==========================================
Files 11 11
Lines 2216 2246 +30
==========================================
+ Hits 2104 2134 +30
Misses 112 112 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #136 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
template-variable
branch
from
48e991a
to
1c7a0ae
Compare
…mpilerOptions.paths closes #129 NOTE: All tests cases are just a head replacement of `${configDir}`, so we are constrained as such. Reference: microsoft/TypeScript#58042
Boshen
force-pushed
the
template-variable
branch
from
1c7a0ae
to
1a26fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #129
NOTE: All tests cases are just a head replacement of
${configDir}/in the typescript test suite, so we are constrained as such.configDiris always an absolute path, so we just join the path instead of replacing it.