Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve normalize_with function #153

Merged
merged 1 commit into from
May 1, 2024
Merged

refactor: improve normalize_with function #153

merged 1 commit into from
May 1, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented May 1, 2024

No description provided.

Copy link

codspeed-hq bot commented May 1, 2024

CodSpeed Performance Report

Merging #153 will improve performances by 5.22%

Comparing normalize (36e9e31) with main (4c498cc)

Summary

⚡ 1 improvements
✅ 1 untouched benchmarks

Benchmarks breakdown

Benchmark main normalize Change
resolver[multi-thread] 2.8 ms 2.6 ms +5.22%

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.69%. Comparing base (27f6500) to head (36e9e31).
Report is 2 commits behind head on main.

Files Patch % Lines
src/path.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          11       11           
  Lines        2297     2301    +4     
=======================================
+ Hits         2221     2225    +4     
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen changed the title chore: test windows path refactor: improve normalize_with function May 1, 2024
@Boshen Boshen merged commit dfc4af4 into main May 1, 2024
20 checks passed
@Boshen Boshen deleted the normalize branch May 1, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant