fix: windows path with C:// like prefixes #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #92 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 93.50% 93.52% +0.01%
==========================================
Files 11 11
Lines 2172 2177 +5
==========================================
+ Hits 2031 2036 +5
Misses 141 141 ☔ View full report in Codecov by Sentry. |
Boshen
changed the title
normalize_with instead of join because the file can be an absolute path by accident
ematipico
reviewed
Feb 20, 2024
Comment on lines
+263
to
+266
| debug_assert!(Path::new(specifier) | ||
| .components() | ||
| .next() | ||
| .is_some_and(|c| matches!(c, Component::Normal(_)))); |
There was a problem hiding this comment.
It would be nice to add a message in the assertion that explains the assertion itself. At the moment there isn't much context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.