oxlint: max-lines should not display offending code

[aparajita]

When max-lines fails, it displays the entire file — which could be several hundred lines — as offending code. This is clearly unnecessary and undesirable.

[aparajita]

Thank you, what will it display now?

[Dunqing]

Thank you, what will it display now?

will now only report lines that exceed the maximum allowed

[aparajita]

Honestly it isn't necessary to display any lines. Because if the file is too long, we can easily end up moving entire functions, and it would be sheer luck if they happened to be at the end of the file. So I would submit that showing excess lines is not at all helpful in most cases to the process of shortening the file.

[mysteryven]

Because if the file is too long, we can easily end up moving entire functions, and it would be sheer luck if they happened to be at the end of the file.

I agree with this, so initially I think it is OK to report all lines and let the user choose which part needs to be deleted. after all, people open this rule, they need to fix it, although it does get a little annoying.

I would submit that showing excess lines is not at all helpful in most cases to the process of shortening the file.

I think some people will encounter this error when they are writing code in this file line by line, it's friendly to notice them they write too many lines, they may decide to write remain part in another file.

Look through ESLint's issue about max-line, not find folk's report about this(perhaps I missed it), I think we can follow the ESLint behavior for now.

[aparajita]

Fair enough. Then how about adding a config option to not display the offending lines?