Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: rule to enforce usage of node: prefix for Node.js built-ins #3161

Closed
Boshen opened this issue May 4, 2024 · 4 comments · Fixed by #3171
Closed

linter: rule to enforce usage of node: prefix for Node.js built-ins #3161

Boshen opened this issue May 4, 2024 · 4 comments · Fixed by #3171
Assignees
@Boshen
Labels
A-linter Area - Linter C-enhancement Category - New feature or request

Comments

@Boshen
Copy link
Member

Boshen commented May 4, 2024

@Boshen Boshen added C-enhancement Category - New feature or request good first issue Experience Level - Good for newcomers A-linter Area - Linter labels May 4, 2024
@Boshen Boshen assigned Boshen and unassigned Boshen May 4, 2024
@hyf0
Copy link
Contributor

hyf0 commented May 5, 2024

Really need this rule in rolldown's repo. We have met a lot PRs to help us adding node: prefix. It would be good if we have a lint rule to catch it in the linting.

@1zumii
Copy link
Contributor

1zumii commented May 6, 2024

is this rule functions same as unicorn/prefer_node_protocol, which is already in oxlint

@Boshen
Copy link
Member Author

Boshen commented May 6, 2024

Oops, it gets ignored when it's in the style category, let me fix things a little bit.

@Boshen Boshen self-assigned this May 6, 2024
@Boshen Boshen removed the good first issue Experience Level - Good for newcomers label May 6, 2024
Boshen added a commit that referenced this issue May 6, 2024
@Boshen
refactor(linter): clean up prefer_node_protocol and move to restriction
5138aa7 
closes #3161
@Boshen Boshen mentioned this issue May 6, 2024
Merged
Boshen added a commit that referenced this issue May 6, 2024
@Boshen
refactor(linter): clean up prefer_node_protocol and move to restricti…
a84454c 
…on (#3171)

closes #3161
@Uzlopak
Copy link

Uzlopak commented May 6, 2024

Thank you for this decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(linter): clean up prefer_node_protocol and move to restriction oxc-project/oxc
4 participants
@Boshen @Uzlopak @1zumii @hyf0