Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter) eslint-plugin-react: react-in-jsx-scope #1025

Merged
merged 7 commits into from
Dec 10, 2023

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Oct 21, 2023

No description provided.

@github-actions github-actions bot added the A-linter Area - Linter label Oct 21, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2023

CodSpeed Performance Report

Merging #1025 will not alter performance

Comparing camc314:c/react-in-scope (f2dbc67) with main (b425b73)

Summary

✅ 20 untouched benchmarks

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walking up the scope is slow, let's try and add a fast path for it.

Boshen
Boshen previously requested changes Oct 26, 2023
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase and a fast path.

@Boshen
Copy link
Member

Boshen commented Nov 15, 2023

@mysteryven Can you help us land this PR?

@mysteryven
Copy link
Member

mysteryven commented Nov 15, 2023

Can you help us land this PR?

Of course, let me try.

@mysteryven
Copy link
Member

mysteryven commented Dec 3, 2023

I guess you have been busy recently, do you mind me helping resolve the conflicts and merge it?

@mysteryven mysteryven dismissed Boshen’s stale review December 10, 2023 09:08

fast path has been added

@mysteryven mysteryven merged commit 9bea278 into oxc-project:main Dec 10, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants