Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter) Improve span for jsx key #1040

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix(linter) Improve span for jsx key #1040

merged 2 commits into from
Oct 23, 2023

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Oct 23, 2023 •
edited

closes #1034

@github-actions github-actions bot added the A-linter Area - Linter label Oct 23, 2023
@camc314 camc314 requested a review from Boshen October 23, 2023 10:08
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2023 •
edited

CodSpeed Performance Report

Merging #1040 will not alter performance

Comparing camc314:c/improve-jsx-key-span (af0f8fe) with main (befc26a)

Summary

✅ 22 untouched benchmarks

@Boshen Boshen merged commit 2483e5c into oxc-project:main Oct 23, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the error span on jsx-key
2 participants
@camc314 @Boshen