Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): noTemplateLiterals configuration in no_string_refs rule not working #1063

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(linter): noTemplateLiterals configuration in no_string_refs rule not working #1063

merged 1 commit into from
Oct 26, 2023

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 25, 2023

I didn't notice that the noTemplateLiterals configuration didn't work due to the lack of test cases

@github-actions github-actions bot added the A-linter Area - Linter label Oct 25, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2023

CodSpeed Performance Report

Merging #1063 will not alter performance

Comparing Dunqing:fix/linter/react/no-string-refs/configuration (d0dadd3) with main (47837e5)

Summary

✅ 22 untouched benchmarks

@Boshen Boshen merged commit 59660a5 into oxc-project:main Oct 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dunqing @Boshen